[DO NOT MERGE] clang-tidy ui.cpp #78616
Open
+23
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Info / User Interface
github-actions
bot
added
astyled
github-actions
bot
added
the
Code: Tests
moxian
force-pushed
the
tidy
branch
3 times, most recently
from
e88f729 to
2845dcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Summary
None
Purpose of change
In #78398 I introduced some clang-tidy errors since I'm still a bit rusty with my C++. This pr fixes them (and some preexisting ones).
Also fixes some unrelated test problems, because github complains about those.
Additional context
For some reason my local clang-tidy shows more errors than github-actions does. I'm not sure why yet.
[DO NOT MERGE] yet. I want to double-check that my fixes satisfy github. Normally I would open this PR as draft and check that way, but I have recently learned that moving a PR from draft to not-draft restarts all the checks, and that is counterproductive. Hence the tag.
I'll remove it as soon as.