Various misc improvements to camp crafting #78612
Open
+31
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Hide errant message claiming camp NPCs can't craft liquid -Update non-camp crafting message to say that liquid crafting IS available at camps -Give the player a notice if there's nobody assigned to work at camp, instead of just silently not crafting -Extract crafting mission's description for translation -Pre-check and WARN if we don't have anywhere to store liquid before the crafting is assigned
github-actions
bot
added
Info / User Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "Various misc improvements to camp crafting flow and feedback"
Purpose of change
Describe the solution
-Hide errant message claiming camp NPCs can't craft liquid
-Update non-camp crafting message to say that liquid crafting IS available at camps
-Give the player a notice if there's nobody assigned to work at camp, instead of just silently not crafting
-Extract crafting mission's description for translation
-Pre-check and WARN if we don't have anywhere to store liquid before the crafting is assigned
-Cleaned up a case where I assigned the same
recipe *to two separate variables in the start_crafting function. Oops. Use only one variable insteadDescribe alternatives you've considered
Perhaps we could short-circuit the "Choose crafter" hotkey in the crafting GUI to notify the player that crafter selection takes place afterwards. But that sounded like a bit more effort than needed.
Testing
Compiled, loaded. Tried to craft without anyone assigned at camp, it cancelled and warned me there was nobody available. Assigned someone. Crafted some wooden beams. Crafted some alcohol.
Additional context