Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] The Great Damage Randomization and Normalization #78611

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Dec 16, 2024

Summary

Mods "[Magiclysm] The Great Damage Randomization and Normalization"

Purpose of change

Or as we called this kind of thing when I played World of Warcraft, "nerfalization"

The spellcasting proficiencies are really neat but no existing spells were updated to account for them, which means that already-powerful Magiclysm combat spells would gain an additional +30% damage bonus at Master proficiency level. I don't want to remove the proficiencies and that leaves only one option--nerfing damage.

Also, when Magiclysm was first created the RANDOM_DAMAGE flag could only allow you to randomize between the maximum possible damage at max level and the minimum possible for your current level, so it could only make spells more powerful. That's not true anymore thanks to math, and since damage numbers everywhere else in the game are random, spell damage should be too.

Describe the solution

Reduce damaging spell damage pretty much across the board.

Randomize spell damage using the RANDOM_DAMAGE spell flag and math statements so you can't predict your spell's damage.

Describe alternatives you've considered

Testing

Line count might be an issue, we'll see if this needs more than one PR

Additional context

@Standing-Storm Standing-Storm marked this pull request as draft December 16, 2024 18:09
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod Mechanics: Enchantments / Spells Enchantments and spells labels Dec 16, 2024
@github-actions github-actions bot requested a review from KorGgenT December 16, 2024 18:09
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 16, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant