typified creature.h and monster.h #78565
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NPC / Factions
github-actions
bot
added
json-styled
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
astyled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Replace usage of untyped coordinates with typed ones.
Describe the solution
Changed operations in creature.h and monster.h to using typed coordinates and adjusting usages of those to use typed coordinates. A large part was to change usage of .pos() to .pos_bub().
There was also a bit of change from using pos(_bub).[x/y/z] to posx/y/z as a simplification.
Describe alternatives you've considered
Testing
As there were no functional changes, there's no particular thing to test.
Loaded save, walked up ramp, jumped into car, drove through hay bales, ran over zombie corpse with inventory, ran over turkey, crashed into stationary vehicle. Nothing odd seen.
Additional context
The continuation of this phase will be to deal with character.h and npc.h (avatar.h has been processed earlier), and then their .cpp files. Since the project uses the practice of dumping implementation into "random" files rather than the corresponding .cpp files a lot will probably be missed, and so will have to be dealt with in future alphabetic file processing.