Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apparel in school itemgroups spawns UNDERSIZE #77480

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

Karol1223
Copy link
Contributor

Summary

None

Purpose of change

It was pointed out football armor found in schools can be worn by any character. Given how clothes found on zombie children are too small to fit, I figured apparel found in areas teeming with zombie children should be as well. Mouse mutants, rejoice

Describe the solution

Describe alternatives you've considered

Testing

Additional context

This does not affect, for obvious reasons, umbrellas, nor does it affect bags, suitcases, or mouthpieces

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Oct 31, 2024
@ampersand55
Copy link
Contributor

Some other itemgroups used by children that could get the same treatment:

"id": "accesories_personal_unisex_child",

"id": "female_underwear_top_child",

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 31, 2024
@Karol1223
Copy link
Contributor Author

Some other itemgroups used by children that could get the same treatment:

The second half of those is, I believe, only used in child zombie death drops and their size is handled over there (that group has UNDERSIZE applied on everything). If memory serves me right, with the way I set up both child_items groups they shouldn't have any apparel, but I'll double check. gym_school seems to definitely warrant the same treatment, though.

@Karol1223 Karol1223 marked this pull request as draft October 31, 2024 16:18
@Karol1223 Karol1223 marked this pull request as ready for review October 31, 2024 18:32
@Maleclypse Maleclypse merged commit d1bcbc0 into CleverRaven:master Nov 2, 2024
19 of 33 checks passed
@Karol1223 Karol1223 deleted the armor-for-rats branch November 2, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants