Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMake build after adding freetype #77360

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix CMake build after adding freetype #77360

merged 1 commit into from
Oct 28, 2024

Conversation

alef
Copy link
Contributor

@alef alef commented Oct 26, 2024

Summary

Build "Fix CMake build after adding freetype"

Purpose of change

Fix CMake build after #76529.

Describe the solution

Add freetype include, remove unnecessary absolute paths in third-party/ CMake file.

Describe alternatives you've considered

None

Testing

Built on Windows and Linux.

Additional context

Hardcoded /usr/include/freetype2 but should come from discovery.

@github-actions github-actions bot added Code: Build Issues regarding different builds and build environments <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 26, 2024
@alef alef marked this pull request as ready for review October 26, 2024 19:14
@alef
Copy link
Contributor Author

alef commented Oct 27, 2024

#77370 refers for failing Makefile CI on macOS

@Maleclypse Maleclypse merged commit f08c753 into CleverRaven:master Oct 28, 2024
34 of 41 checks passed
@alef alef deleted the cmake_imgui_freetype branch October 28, 2024 17:01
@LyleSY LyleSY mentioned this pull request Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Code: Build Issues regarding different builds and build environments json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alef @Maleclypse