Update Catch2 to v2.12.0 (from 2.9.1) #39797
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Update Catch2 to v2.12.0 (from 2.9.1)"
Purpose of change
To keep up to date with upstream improvements.
Describe the solution
This includes the upstreamed version of #39441, with some improvements from what was commited here. And various other improvements too. See the Catch2 changelog for details.
Had to add one
NOLINT
for our custom Cata clang-tidy tests, but otherwise this is the upstream header.Describe alternatives you've considered
There were no specific requirements from the new version I thought we needed, so this isn't strictly necessary. It's mostly to make us no longer be using a custom fork of Catch2.
Testing
Ran unit tests.