Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sum v1.1bugfix #279

Merged
merged 3 commits into from
Jan 21, 2021
Merged

Sum v1.1bugfix #279

merged 3 commits into from
Jan 21, 2021

Conversation

yinchuangsum
Copy link
Contributor

Description

Fix aspect ratio bug.
https://drive.google.com/drive/folders/1tPOXrJjfDXYkzED4Zkm2Ch23Q5U1PuJC?usp=sharing
Test images provided.
You may test with the old version, then test with this latest version. But you need to reimport the image to have correct aspec ratio and thumnails

Fixes #252

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tested on?

  • [ x] Windows
  • [ x] Linux Ubuntu
  • [ x] Centos
  • Mac
  • Others (State here -> xxx )

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@yinchuangsum yinchuangsum added the fix done fixing label Jan 21, 2021
@yinchuangsum yinchuangsum self-assigned this Jan 21, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codenamewei codenamewei merged commit 02d7f79 into main Jan 21, 2021
@yinchuangsum yinchuangsum deleted the sum_v1.1bugfix branch January 28, 2021 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix done fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aspect ratio is not correct for certain edited images
2 participants