Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aspect ratio is not correct for certain edited images #252

Closed
yinchuangsum opened this issue Jan 6, 2021 · 0 comments · Fixed by #279
Closed

Aspect ratio is not correct for certain edited images #252

yinchuangsum opened this issue Jan 6, 2021 · 0 comments · Fixed by #279
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed medium priority need to fix, it block some features function

Comments

@yinchuangsum
Copy link
Contributor

Describe the bug
Some images which are change from horizontal to vertical or vice versa are having issue that the orientation of the images are changed but remain at the old aspect ration (which means it is stretched)

To Reproduce
Steps to reproduce the behavior:

  1. Rotate an image
  2. Load it into classifai
  3. Some of the images are having such issue

Expected behavior
The image should have the right aspect ratio

Screenshots
Screenshot_2021-01-06-18-56-37-97.jpg

Desktop (please complete the following information):

  • OS: Ubuntu 20.04
  • Browser: Chromium
  • Version: 1.0.0

Additional context
For the images having such issue, the properties is also allocate the aspect ratio wrongly.
However other image viewer do not suffer such issue.
@codenamewei codenamewei added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed medium priority need to fix, it block some features function labels Jan 7, 2021
yinchuangsum added a commit that referenced this issue Jan 21, 2021
@yinchuangsum
bug fix #252
2685f42
@yinchuangsum yinchuangsum mentioned this issue Jan 21, 2021
Merged
8 tasks
codenamewei added a commit that referenced this issue Jan 21, 2021
@codenamewei
Merge pull request #279 from CertifaiAI/sum_v1.1bugfix
02d7f79 
#252 Image Orientation Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed medium priority need to fix, it block some features function
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sum v1.1bugfix CertifaiAI/classifai
2 participants
@codenamewei @yinchuangsum