Small fixes after pylint/flake cleanup

[dagwieers]

Check if this PR fulfills these requirements:

• My changes respect the Kodi add-on development rules
• I have read the CONTRIBUTING document.
• I made sure there wasn't another one Pull Requests opened for the same update/change
• I have successfully tested my changes locally

Types of changes

• New feature (non-breaking change which adds functionality)
• Feature change (non-breaking change which change behaviour of an existing functionality)
• Improvement (non-breaking change which improve functionality)
• Bug fix (non-breaking change which fixes an issue)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

After reviewing #194 after an issue (#217) was found, I found one other issue.
Which this PR fixes.

[Smeulf]

Both are technically correct right? I mean the result will be the same(?)

Plus it seems to me that your code will test for videoId.mediatype value once more than the previous code (I am wrong?)

I don't understand why you fight 'elif', I'd be glad if you can explain deeper so I can learn.

[Smeulf]

Got it!

In the former code, we were doing an action for mediatype=MOVIE or for mediatype=SHOW.
In your code before the fix, if the type is MOVIE, the code will jump to for season_key in item.keys(): and run into an error.

So this fix is very right.

[dagwieers]

As most of the source code, annotations would be helpful 😉

[Smeulf]

I agree, and have to admit that piece of code I wrote was not a model of art...

[dagwieers]

@Smeulf There is no real issue with the code, but I learned earlier this year something called return early or guard code and it is something I unknowingly was practising already to keep indentation to a minimum (and readability to a maximum).

It is very pythonic and well-explained here: https://openfolder.sh/returning-early

[Smeulf]

And by extension, it reduces the code complexity if I'm correct.