Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix perpetual_path_request after Pylint fixes #217

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Fix perpetual_path_request after Pylint fixes #217

merged 1 commit into from
Sep 18, 2019

Conversation

Smeulf
Copy link

@Smeulf Smeulf commented Sep 18, 2019

Check if this PR fulfills these requirements:

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Feature change (non-breaking change which change behaviour of an existing functionality)
  • Improvement (non-breaking change which improve functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fix a regression in perpetual_path_request after Pylint fixes

@Smeulf Smeulf mentioned this pull request Sep 18, 2019
Merged
9 tasks
dagwieers
dagwieers reviewed Sep 18, 2019
View reviewed changes
resources/lib/services/nfsession/nfsession.py
@@ -296,7 +296,6 @@ def perpetual_path_request(self, paths, length_params, perpetual_range_start=Non
.format(response_type))
else:
range_end = range_start + request_size
break
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, there's indeed a runaway break there :-(
bf10972

Copy link
Contributor

@dagwieers dagwieers Sep 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found another issue introduced by that PR. (Everything else looks fine after reviewing)
See #218

@dagwieers dagwieers mentioned this pull request Sep 18, 2019
Merged
9 tasks
@Smeulf Smeulf changed the base branch from verbump to master September 18, 2019 17:09
@Smeulf Smeulf changed the base branch from master to verbump September 18, 2019 17:09
@Smeulf Smeulf changed the base branch from verbump to master September 18, 2019 17:14
@CastagnaIT CastagnaIT merged commit ccff1a0 into CastagnaIT:master Sep 18, 2019
@Smeulf Smeulf deleted the verbump branch September 19, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagwieers dagwieers dagwieers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Smeulf @dagwieers @CastagnaIT