fix simplex traverser for CGAL 5.6 #7535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the moment, that new test fails.
- call the API with two vertex handles, when possible, - add a check that the reported simplices intersect the query segment, - add a chech that two consecutive simplices are incident.
Protected by the macro CGAL_DEBUG_TRIANGULATION_SEGMENT_TRAVERSER_3
with tests on cell_iterator == end()
and then avoid all std std::get<i>(simplex), hard to read
* test_segment_simplex_traverser_3 first failing test is now "032" * the geometric intersection test fails because of doubles
The test-case was wrong.
`-.1`, and `.8` are not floating point values. I have used `.125` (1/8) and `.5` instead.
Jane and I thought that case vertex-vertex with `ch_next != Cell_handle()` was not possible. Let's patch that.
…ation_3-fix_simplex_traverser-GF-CGAL-5.6
sloriot
added a commit
to sloriot/cgal
that referenced
this pull request
Jun 22, 2023
…_traverser-GF-CGAL-5.6 fix simplex traverser for CGAL 5.6
sloriot
added
Batch_1
|
Successfully tested in CGAL-6.0-Ic-15 |
sloriot
added
Tested
and removed
Ready to be tested
Under Testing
Batch_1
lrineau
added
rm only: ready for master
lrineau
added a commit
that referenced
this pull request
Jul 5, 2023
…verser-GF-CGAL-5.6 fix simplex traverser for CGAL 5.6
lrineau
removed
rm only: ready for master
|
This PR partially solves issue #7438 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
equivalent of #7423, integration branch and PR for
5.6.x-branch,master, andintegration.