Triangulation_3: Fix a bug in tr.segment_traverser_simplices() #7423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrineau
changed the title
janetournois
approved these changes
May 4, 2023
For the moment, that new test fails.
- call the API with two vertex handles, when possible, - add a check that the reported simplices intersect the query segment, - add a chech that two consecutive simplices are incident.
lrineau
force-pushed
the
Triangulation_3-fix_simplex_traverser-GF
branch
from
a50aa7a to
152f003
Compare
Protected by the macro CGAL_DEBUG_TRIANGULATION_SEGMENT_TRAVERSER_3
lrineau
force-pushed
the
Triangulation_3-fix_simplex_traverser-GF
branch
from
d4b0034 to
7260a94
Compare
with tests on cell_iterator == end()
and then avoid all std std::get<i>(simplex), hard to read
Jane and I thought that case vertex-vertex with `ch_next != Cell_handle()` was not possible. Let's patch that.
lrineau
added
the
rm only: ready for release branch
lrineau
removed
rm only: ready for release branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fix a bug in
tr.segment_traverser_simplices()in the case vertex-facet-edge-cell-vertex.Release Management