Add stop button for AW3 demo #7500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No changes to existing oracles as AW3's oracles use a shared ptr to AABB Tree
MaelRL
added
Enhancement
Not yet approved
lrineau
reviewed
Jun 8, 2023
Comment on lines
+300
to
+304
| void emit_status() | ||
| { | ||
| Q_EMIT status_report(QString("%1 vertices").arg(wrapper.triangulation().number_of_vertices())); | ||
| } | ||
|
|
There was a problem hiding this comment.
That is the only place where I might see an issue. But the Mesh_3 plugin has the same: the timer is created and started in the main thread, so this slot will be called by the main thread. The call wrapper.triangulation().number_of_vertices() is not thread-safe. However, the only consequence I can see is a possible incoherent number of vertices during one iteration of the slot.
There was a problem hiding this comment.
That is related to the macro CGAL_CONCURRENT_COMPACT_CONTAINER_APPROXIMATE_SIZE from PR #4389.
Polyhedron/demo/Polyhedron/Plugins/Alpha_wrap_3/Alpha_wrap_3_plugin.cpp
Outdated
Show resolved
Hide resolved
sloriot
added
Batch_2
|
Successfully tested in CGAL-6.0-Ic-1 |
MaelRL
removed
Not yet approved
sloriot
added a commit
to sloriot/cgal
that referenced
this pull request
Jun 22, 2023
Add stop button for AW3 demo
sloriot
added
Batch_1
|
Successfully tested in CGAL-6.0-Ic-15 |
lrineau
added
the
rm only: ready for master
lrineau
removed
the
rm only: ready for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Management
Polyhedron,Alpha_wrap_3