Fix DT3 parallel performance loss (issue #4388) #4389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrineau
force-pushed
the
DT_3-issue4388-GF
branch
3 times, most recently
from
5402f2f to
014ae90
Compare
Instead of having an atomic integer for the size of the compact container, now all free lists have an atomic integer for their size, but it is only updated when the size is increased by 10%.
…__for_CGAL-4.14.2-GF
lrineau
force-pushed
the
DT_3-issue4388-GF
branch
from
014ae90 to
6cdd833
Compare
lrineau
added
Bug
Pkg::STL_Extension
Pkg::Triangulation_3
Parallel_tag
rm only: release blocker
lrineau
changed the title
|
This PR is really important for @maxGimeno: Please test it as soon as possible. |
|
Successfully tested in https://cgal.geometryfactory.com/CGAL/testsuite/results-5.1-Ic-31.shtml |
lrineau
added
the
rm only: ready for master
lrineau
added a commit
that referenced
this pull request
Dec 17, 2019
Fix DT3 parallel performance loss (issue #4388)
lrineau
added a commit
that referenced
this pull request
Dec 17, 2019
Fix DT3 parallel performance loss (issue #4388)
lrineau
removed
Master Version of Release Branch PR
Ready to be tested
Under Testing
rm only: ready for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fix #4388.
This fixes the performance loss.
With the macro
CGAL_CONCURRENT_COMPACT_CONTAINER_APPROXIMATE_SIZEdefined to1, then theConcurrent_compact_containerimplements a functionapproximate_size(), but at a cost of 3% of performance loss, even if the function is not used (to maintain the atomic values).Release Management
PR #4392 is the same patch, but for the branch of 4.14.x.