Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps azure/login from 1 to 2.2.0 #8324

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shanice-skylight
Copy link
Collaborator

@shanice-skylight shanice-skylight commented Nov 27, 2024

DEVOPS PULL REQUEST

Related Issue

  • While updating credentials for Azure and terraform, noticed that azure/login was behind on an update an not consistent in all modules.
  • Bumps azure/login from 1 to 2.2.0.

Changes Proposed

  • Modify all azure/login version to 2.2.0

Additional Information

  • Deployed to dev2

Testing

  • How should reviewers verify this PR?

Copy link

sonarcloud bot commented Nov 27, 2024

@shanice-skylight shanice-skylight changed the title Shanice/creds update Bumps azure/login from 1 to 2.2.0 Dec 2, 2024
@shanice-skylight shanice-skylight marked this pull request as ready for review December 2, 2024 16:33
@shanice-skylight shanice-skylight self-assigned this Dec 2, 2024
@shanice-skylight shanice-skylight requested review from DanielSass, a team, emyl3 and mpbrown and removed request for a team December 2, 2024 19:50
@@ -23,7 +23,7 @@ jobs:
ARM_TENANT_ID: ${{ secrets.TERRAFORM_ARM_TENANT_ID }}
steps:
- uses: actions/checkout@v4
- uses: azure/login@v2
- uses: azure/login@v2.2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question for my own understanding... Is there a reason we want to specify the minor version in this change? It looks like v2 tag without a minor version specified points to v2.2.0 🤔

Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one question for you, Shanice! Thank you for catching this!

Copy link
Collaborator

@DavidMcClatchey DavidMcClatchey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@mpbrown mpbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants