Mock the Census API for tests so that Actions doesn't actually hit the API when running tests #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #864 +/- ##
==========================================
- Coverage 96.40% 96.37% -0.04%
==========================================
Files 46 46
Lines 2645 2645
==========================================
- Hits 2550 2549 -1
- Misses 95 96 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
robertmitchellv
requested review from
DanPaseltiner,
m-goggins and
emmastephenson
|
@emmastephenson rightly pointed out that there are also geocoding functions running in the |
DanPaseltiner
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
LGTM! Nice work @robertmitchellv. I'm going to have to read the docs on @pytest.fixture and use it the next time I'm writing unit tests. 🚀
emmastephenson
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Mock the Census API for tests so that Actions doesn't actually hit the API when running tests. If there is any kind of rate limiting or issue with the external API we don't want that to halt our ability to merge PRs.
Related Issue
Fixes #861
Additional Information
This is important so that when other tickets are completed and you want to merge to main you are not stopped because a unit test for code you're not working on is failing because it's actually hitting an external API and erroring out.