Orchestration service happy path #829
Conversation
containers/orchestration/tests/test_process_message_endpoint.py
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
|
|
||
| def validation_payload(**kwargs) -> dict: |
There was a problem hiding this comment.
Dumb question, but what are these payload definitions used for?
There was a problem hiding this comment.
They define how each service needs it request defined. Some of them have different requirements, so we define each
| "ingestion": { | ||
| "url": "http://localhost:8083" | ||
| }, | ||
| "standardization_and_geocoding": { |
There was a problem hiding this comment.
Should standardization & geocoding be sub-fields under ingestion? That seems to be the standard with the other BBs.
There was a problem hiding this comment.
I'd maybe have a preference to just read the sample configuration in the tests instead of keeping a second tests config - I think it would be easy for them to come out of sync.
There was a problem hiding this comment.
That's a good point, but the one issue is that the test config drops geocoding so we don't have to worry about smarty creds/geocode failures. We'd have to come up with another way of dodging that
There was a problem hiding this comment.
Ahhh gotcha. Could you make a ticket for this so we remember to follow up on it?
|
|
||
| def unzip(zipped_file) -> Dict: | ||
| my_zipfile = ZipFile(zipped_file.file) | ||
| file_to_open = [file for file in my_zipfile.namelist() if "/CDA_eICR.xml" in file][ |
There was a problem hiding this comment.
This can be for a followup PR, but I think we also need to look for the RR file here and pass that to services as appropriate.
PULL REQUEST
Summary
Howdy howdy howdy.
Here's orchestration running on a default config and hitting Validation, FHIR Converter, Ingestion (Standardizing DOB, Phone, Name, and Geocoding), and the message parser that Nick and I wrote up.
This is happy path, not much in the way of accounting for individual step failures etc. This is because we wanted to check with the team on what exactly we want to happen on step failures and ALSO because the fix could either be handled here or there are some updates and optimizations that could be done on the BB endpoints to mitigate issues, e.g. making sure the bundle sent is always returned even on a failure.
Looking forward to feedback, cheers!
Ticket
https://app.zenhub.com/workspaces/secret-6480bf2ee530095ab41ebbe9/issues/gh/cdcgov/phdi/785