-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix eicr id in FHIR Converter and in ECR Datastore - add additional identifier fields #795
Conversation
…l as related documents and their ids/references
Codecov Report
@@ Coverage Diff @@
## main #795 +/- ##
=======================================
Coverage 96.42% 96.42%
=======================================
Files 45 45
Lines 2626 2626
=======================================
Hits 2532 2532
Misses 94 94
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! liquid is 😵
…er or reference, not both)
I have tested the resulting FHIR Bundle in our AZure FHIR server and it uploaded without any errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
PULL REQUEST
Summary
LAC Has requested that we include eICR set id to the ECR datastore and in so doing, we realized we may not have been pulling the correct fields for eICR id. We have made the following changes to fulfill LAC request and to include more identifiers:
FHIR Converter Changes
ECR Datastore Changes
Related Issue
Fixes #https://app.zenhub.com/workspaces/skylight-dibbs-viper-6480ba23b5a07644e0e46d23/issues/gh/cdcgov/phdi-google-cloud/113