Handle empty travel histories as unavailable data #3005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o mcm/enc-car-team
update docker compose seed file name
mcmcgrath13
commented
Dec 6, 2024
| @@ -21,12 +21,6 @@ export interface TableJson { | |||
| tables?: TableRow[][]; | |||
| } | |||
|
|
|||
| export interface TableJson { | |||
There was a problem hiding this comment.
this is a duplicate of the definition immediately above
mcmcgrath13
commented
Dec 9, 2024
containers/ecr-viewer/src/app/services/evaluateFhirDataService.ts
Outdated
Show resolved
Hide resolved
mcmcgrath13
requested review from
BobanL,
angelathe,
JNygaard-Skylight,
lina-roth,
gordonfarrell and
austin-hall-skylight
BobanL
approved these changes
Dec 9, 2024
containers/ecr-viewer/src/app/services/socialHistoryService.tsx
Outdated
Show resolved
Hide resolved
BobanL
reviewed
Dec 9, 2024
containers/ecr-viewer/src/app/tests/components/EvaluateTable.test.tsx
Outdated
Show resolved
Hide resolved
…DCgov/phdi into mcm/fix-phantom-travel-history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
If a travel history observation exists, but has no useful data, treat it as unavailable data instead of rendering a table with rows full of
No Data.Related Issue
Fixes #2978
Additional Information
http://localhost:3000/view-data?id=d9039113-a9e0-4ae4-a8c6-6b46327d3af8
Before:
After:
