fix: consistent spacing between sub-sections, reactify #2955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmcgrath13
requested review from
BobanL,
lina-roth,
angelathe,
ashton-skylight,
gordonfarrell,
JNygaard-Skylight and
austin-hall-skylight
|
Look at that consistent spacing! What px or em is the spacing set to in this example? |
A gutter of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Use a consistent format for accordion sub-sections throughout the ecr viewer.
This PR adds a
AccordionSubSectioncomponent and uses it throughout the viewer to make sure we have consistent spacing, formatting, IDing of sub-sections. This "react-ifies" the code base a bit more. I took some leeway when introducing the sub-component to refactor sections to be a bit more idiomatic React.Related Issue
Fixes #2670
Additional Information
Look at that consistent spacing:
Checklist