fix: add pager (and others) to contact info #2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmcgrath13
commented
Nov 20, 2024
mcmcgrath13
changed the title
mcmcgrath13
requested review from
BobanL,
angelathe,
austin-hall-skylight,
lina-roth,
gordonfarrell and
JNygaard-Skylight
angelathe
reviewed
Nov 21, 2024
containers/fhir-converter/Dockerfile
Outdated
| @@ -1,7 +1,7 @@ | |||
| FROM mcr.microsoft.com/dotnet/sdk:6.0 AS build | |||
|
|
|||
| # Download FHIR-Converter | |||
| RUN git clone https://github.com/skylight-hq/FHIR-Converter.git --branch v7.0-skylight-11 --single-branch /build/FHIR-Converter | |||
| RUN git clone https://github.com/skylight-hq/FHIR-Converter.git --branch mcm/fix-pager --single-branch /build/FHIR-Converter | |||
There was a problem hiding this comment.
Don't think you meant to commit this?
There was a problem hiding this comment.
Oh you might've left this in temporarily for testing -- TY!
There was a problem hiding this comment.
sorry about that - I usually leave a comment to myself to update it to a released version before merging
| "other", | ||
| "", | ||
| ]; | ||
| const sortContacts = (contactPoints: ContactPoint[]): ContactPoint[] => { |
There was a problem hiding this comment.
Could you add a JSDoc for this helper function?
| [faxNumberUse, "Fax:", formatPhoneNumber(contactPoint.value ?? "")] | ||
| .join(" ") | ||
| .trim(), | ||
| [phoneNumberUse, formatPhoneNumber(value)].filter((c) => c).join(": "), |
There was a problem hiding this comment.
Is the .filter((c) => c) still necessary here? Since we're already checking if there's a value on line 601
There was a problem hiding this comment.
Yeah, because Use might be empty and then we don't want the : rendered
There was a problem hiding this comment.
Ooh, good call! Thanks!!
angelathe
approved these changes
Nov 21, 2024
mcmcgrath13
commented
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Counterpart of skylight-hq/FHIR-Converter#13. This pulls in the newly available pager system and generalizes
formatContactPointto work with any of the fhir-supported systems and always return the values in a consistent sort order.Related Issue
Fixes #2729
Fixes #2713
Additional Information