Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use standalone executable to avoid dotnet runtime #2928

Merged
merged 10 commits into from
Nov 20, 2024

Conversation

mcmcgrath13
Copy link
Collaborator

@mcmcgrath13 mcmcgrath13 commented Nov 18, 2024

PULL REQUEST

Summary

Instead of using a dotnet runtime, use a python-slim base. This is enabled by using the publish command instead of build in the build phase of the fhir-converter-service and asking for a standalone linux executable.

Also:

  • build only the tool instead of the whole repo.
  • add cachebusting of only the python service part of the image so you can avoid a dotnet rebuild when not working on that part of the code

Depends on skylight-hq/FHIR-Converter#12

Additional Information

Converter build step timings
before: 3m45s
after: 1m30s

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@mcmcgrath13 mcmcgrath13 marked this pull request as ready for review November 18, 2024 22:07
@mcmcgrath13 mcmcgrath13 requested a review from BobanL November 18, 2024 22:07
Copy link
Collaborator

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@mcmcgrath13 mcmcgrath13 added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit ca8a743 Nov 20, 2024
35 checks passed
@mcmcgrath13 mcmcgrath13 deleted the mcm/publish-fhir-converter branch November 20, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants