Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mutiple names and addresses #2911

Merged
merged 8 commits into from
Nov 15, 2024
Merged

add mutiple names and addresses #2911

merged 8 commits into from
Nov 15, 2024

Conversation

lina-roth
Copy link
Collaborator

@lina-roth lina-roth commented Nov 15, 2024

PULL REQUEST

Example of 1 name or 1 address

Screen Shot 2024-11-15 at 4 04 14 PM Screen Shot 2024-11-15 at 4 04 23 PM

Example of multi name or multi address

Screen Shot 2024-11-15 at 4 04 40 PM Screen Shot 2024-11-15 at 4 04 52 PM

Summary

  • Display all available names and addresses
  • If there is more than 1 address or name, show "use" as well
  • Added boolean to evaluatePatient name for if being used by PatientBanner

Related Issue

Fixes #2740

Acceptance Criteria

  • We would like to display all information that is available to us, including multiple patient names/addresses and their uses (consult w/ design first).

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@ashton-skylight
Copy link
Collaborator

Approved, looks great

@angelathe
Copy link
Collaborator

Code looks good, but could you write some unit tests for this? (evaluatePatientName and evaluatePatientAddress)

Also, I'm not sure if this is related, but for this eCR, the second address just displays "USA".

@lina-roth
Copy link
Collaborator Author

lina-roth commented Nov 15, 2024

@angelathe - added some tests.

For ecr 1.2.840.114350.1.13.478.3.7.8.688883.230886

This is what is in the eICR, I can make a ticket to discuss if we would like to determine what is a valid or invalid address

                <streetAddressLine nullFlavor="UNK"/>
                <city nullFlavor="UNK"/>
                <state nullFlavor="UNK"/>
                <postalCode nullFlavor="UNK"/>
                <country>USA</country>
                <useablePeriod xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:type="IVL_TS">
                    <low value="20171117"/>
                    <high value="20171121"/>
                </useablePeriod>
            </addr>

#2914 created

Copy link
Collaborator

@mcmcgrath13 mcmcgrath13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

thank you!!

@lina-roth lina-roth added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit 70735e9 Nov 15, 2024
11 checks passed
@lina-roth lina-roth deleted the lr/contact-info branch November 15, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Patient multiple contact info not displayed
4 participants