-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mutiple names and addresses #2911
Conversation
Approved, looks great |
Code looks good, but could you write some unit tests for this? ( Also, I'm not sure if this is related, but for this eCR, the second address just displays "USA". |
@angelathe - added some tests. For ecr 1.2.840.114350.1.13.478.3.7.8.688883.230886 This is what is in the eICR, I can make a ticket to discuss if we would like to determine what is a valid or invalid address
#2914 created |
containers/ecr-viewer/src/app/services/evaluateFhirDataService.ts
Outdated
Show resolved
Hide resolved
containers/ecr-viewer/src/app/services/evaluateFhirDataService.ts
Outdated
Show resolved
Hide resolved
containers/ecr-viewer/src/app/services/evaluateFhirDataService.ts
Outdated
Show resolved
Hide resolved
containers/ecr-viewer/src/app/view-data/components/PatientBanner.tsx
Outdated
Show resolved
Hide resolved
containers/ecr-viewer/src/app/tests/services/evaluateFhirDataServices.test.ts
Show resolved
Hide resolved
containers/ecr-viewer/src/app/tests/services/evaluateFhirDataServices.test.ts
Show resolved
Hide resolved
containers/ecr-viewer/src/app/services/evaluateFhirDataService.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
thank you!!
PULL REQUEST
Example of 1 name or 1 address
Example of multi name or multi address
Summary
Related Issue
Fixes #2740
Acceptance Criteria
Checklist