Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add data conversion github action #2910

Merged
merged 16 commits into from
Nov 20, 2024
Merged

Conversation

mcmcgrath13
Copy link
Collaborator

@mcmcgrath13 mcmcgrath13 commented Nov 15, 2024

PULL REQUEST

Summary

Add seed data conversion as a CI job to make sure changes don't inadvertently affect its success.

There are currently a few failing conversions 😢. These are due to genuinely duplicate IDs in eCRs. We should figure out how we want to address those

Also simplified the running steps for conversion by using the include option.

Copy link
Collaborator

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏 👏

Copy link
Collaborator

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought of a change that needs to be made to the npm scripts!

@mcmcgrath13 mcmcgrath13 requested a review from BobanL November 19, 2024 22:10
Copy link
Collaborator

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏 👏 👏 for real this time

@mcmcgrath13 mcmcgrath13 added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 4b5de32 Nov 20, 2024
15 checks passed
@mcmcgrath13 mcmcgrath13 deleted the mcm/ci-seed-conversion branch November 20, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants