Update getDataId to use ID attribute instead of data-id comment #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s since they are no longer added
austin-hall-skylight
requested review from
mcmcgrath13,
BobanL,
lina-roth,
angelathe,
JNygaard-Skylight and
gordonfarrell
mcmcgrath13
reviewed
Nov 8, 2024
mcmcgrath13
reviewed
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Because the xhtml tables in Compositions are now being saved as their raw string representation rather than being converted to html, we are no longer adding element ID's as data-id in comment tags. This updates the getDataId function to look at an element's ID rather than looking for comment tags with data-id in them.
Related Issue
Fixes #2871
Checklist