Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use named queries and format to escape #2826

Merged
merged 2 commits into from
Oct 30, 2024
Merged

use named queries and format to escape #2826

merged 2 commits into from
Oct 30, 2024

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented Oct 29, 2024 •
edited
Loading

PULL REQUEST

Summary

  • use pg-promise format to escape strings

Acceptance Criteria

  • Strings are escaped when queried
  • Prevent sql injection

image

Additional Information

  • Replaced toHaveBeenCalledWithExactlyOnce because there is currently an issue jest-extend where it does not show errors with anything other than the first parameter.

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@BobanL BobanL changed the title use named queries and pgPromise's format to escape use named queries and format to escape Oct 29, 2024
@BobanL BobanL marked this pull request as ready for review October 29, 2024 16:27
@BobanL BobanL enabled auto-merge October 29, 2024 16:36
austin-hall-skylight
austin-hall-skylight approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@austin-hall-skylight austin-hall-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great!

@BobanL BobanL added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 4b28f89 Oct 30, 2024
11 checks passed
@BobanL BobanL deleted the boban/fix-search-escaped branch October 30, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austin-hall-skylight austin-hall-skylight austin-hall-skylight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BobanL @austin-hall-skylight