perf: send seed data requests asynchronously #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmcgrath13
requested review from
BobanL,
JNygaard-Skylight and
austin-hall-skylight
BobanL
reviewed
Nov 9, 2024
There was a problem hiding this comment.
I'm not sure on other machines, but locally I'm actually getting slower results.
Async: 10:09:11 - 10:12:45 = 3 minutes 34 seconds
Sync: 10:16:11 - 10:19:36 = 3 minutes 25 seconds
There was a problem hiding this comment.
Async ran for me in 5:17 while sync was 6:10.
There was a problem hiding this comment.
so almost a minute improvement, not great, not awful
Should we go ahead and merge? or any concerns about adding the async-ness in general?
There was a problem hiding this comment.
It looks good to me! I was testing around with lower memory / cpu and got similar results to Mary's!
BobanL
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Use asynchronous requests when converting seed data. Locally, this speeds up conversion from 8:45 to 5:12
create-seed-data-pyscript into two phases: 1) gathering all the requests to send, 2) sending all the requests async and handling responsesn of totalprinting, which I find a nicer ux