Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecr-viewer: set url.hostname to x-forwarded-host #2630

Merged
merged 2 commits into from
Sep 26, 2024
Merged

ecr-viewer: set url.hostname to x-forwarded-host #2630

merged 2 commits into from
Sep 26, 2024

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented Sep 26, 2024

PULL REQUEST

Summary

What changes are being proposed?

  • Set hostname to be x-forwarded-host

Related Issue

@BobanL BobanL added this pull request to the merge queue Sep 26, 2024
@BobanL BobanL removed this pull request from the merge queue due to a manual request Sep 26, 2024
@BobanL BobanL enabled auto-merge September 26, 2024 18:11
@BobanL BobanL added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit 8ed3009 Sep 26, 2024
11 checks passed
@BobanL BobanL deleted the boban/set-hostname branch September 26, 2024 18:30
BobanL added a commit that referenced this pull request Sep 27, 2024
@BobanL
Revert "ecr-viewer: set url.hostname to x-forwarded-host (#2630)"
c14aa70 
This reverts commit 8ed3009.
github-merge-queue bot pushed a commit that referenced this pull request Sep 27, 2024
@BobanL
Revert middleware changes and add hostname to dockerfile (#2637)
f16958b 
* Revert "ecr-viewer: set url.hostname to x-forwarded-host (#2630)"

This reverts commit 8ed3009.

* Add hostname and port number to the dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austin-hall-skylight austin-hall-skylight austin-hall-skylight approved these changes

@lina-roth lina-roth Awaiting requested review from lina-roth

@angelathe angelathe Awaiting requested review from angelathe

@gordonfarrell gordonfarrell Awaiting requested review from gordonfarrell

@JNygaard-Skylight JNygaard-Skylight Awaiting requested review from JNygaard-Skylight

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BobanL @austin-hall-skylight