Add s3 path for orchestration #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KennethSkylight
requested review from
nickbristow,
emmastephenson and
gordonfarrell
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
=======================================
Coverage 96.94% 96.94%
=======================================
Files 48 48
Lines 3048 3048
=======================================
Hits 2955 2955
Misses 93 93
Flags with carried forward coverage won't be shown. Click here to find out more. |
nickbristow
approved these changes
Feb 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Orchestration has a step to write to s3. The configuration service name needs to include a save_to_s3 service to load to s3. If you want to run it, you need to add two .env variables that aren't checked in due to security reasons. If you want them, let me know.
Tests will be added on a different PR. Working that in parallel so we can test e2e sooner.
Related Issue
Fixes #1270