Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rule to remove unused imports in ecr viewer #1367

Merged
merged 7 commits into from
Feb 23, 2024
Merged

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented Feb 23, 2024

PULL REQUEST

Summary

There were leftover unused dependencies that should be removed. Install eslint plugin to handle that rule

Related Issue

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.94%. Comparing base (90c47d0) to head (92bee8d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1367   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files          48       48           
  Lines        3048     3048           
=======================================
  Hits         2955     2955           
  Misses         93       93           
Flag Coverage Δ
unit-tests 96.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@BobanL BobanL changed the title Boban/fix linting issues add rule to remove unused imports in ecr viewer Feb 23, 2024
@BobanL BobanL marked this pull request as ready for review February 23, 2024 16:23
@BobanL BobanL added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit 739a50b Feb 23, 2024
39 checks passed
@BobanL BobanL deleted the boban/fix-linting-issues branch February 23, 2024 17:06
@BobanL BobanL mentioned this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants