Add _build_addr method to PHDCBuilder
#1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1070 +/- ##
=======================================
Coverage 96.93% 96.93%
=======================================
Files 48 48
Lines 3037 3037
=======================================
Hits 2944 2944
Misses 93 93
Flags with carried forward coverage won't be shown. Click here to find out more. |
m-goggins
requested review from
DanPaseltiner,
robertmitchellv and
zdeveloper
| @pytest.mark.parametrize( | ||
| "build_addr_test_data, expected_result", | ||
| [ | ||
| # Success with all values present |
There was a problem hiding this comment.
the comment describing the expectation of the test set up data is a good idea 💡
There was a problem hiding this comment.
Much easier for me to keep track as I make the tests too :)
robertmitchellv
approved these changes
Jan 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
This PR adds an internal method for building out the address section of a PHDC.
Related Issue
Fixes #1052
Additional Information
line. PHDC does allow for mutiplelinesin an address or for the address to be condensed on a single line.Checklist