Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add travel history into fhir converter and ecr viewer #1036

Merged
merged 27 commits into from
Jan 12, 2024

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented Jan 9, 2024

PULL REQUEST

Summary

  • Add new observation template for travel history
  • Add travel history to the ecr viewer
  • Add unit tests for travel history

Related Issue

Fixes #1001

Additional Information

  • This currently works with the limited travel history we are given, but this may need more refactor in the future depending on how other examples of travel history look.

image

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (13dab42) 96.93% compared to head (6414115) 96.93%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1036   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files          48       48           
  Lines        3037     3037           
=======================================
  Hits         2944     2944           
  Misses         93       93           
Flag Coverage Δ
unit-tests 96.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@BobanL BobanL marked this pull request as ready for review January 12, 2024 12:54
Copy link
Collaborator

@KennethSkylight KennethSkylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes

containers/ecr-viewer/src/app/utils.tsx Show resolved Hide resolved
containers/ecr-viewer/src/app/utils.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@KennethSkylight KennethSkylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@emmastephenson emmastephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for figuring this one out!

@@ -238,7 +238,12 @@
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice call on updating some of the seed data 👍

@BobanL BobanL added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit e47dae5 Jan 12, 2024
34 checks passed
@BobanL BobanL deleted the boban/1001-extract-travel-history branch January 12, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract patient travel history from eICR; add to eCR Viewer
3 participants