refactor: remove eccvm functionality to update the op queue and ensure ultra ops are populated through function #5084

maramihali · 2024-03-08T12:17:45Z

Resolves AztecProtocol/barretenberg#897.

Add API functionality so we don't populate the ultra_ops manually in the circuit builder and ensure ECCVM cannot update the op_queue and is always constructed from existing op_queue.

Opens AztecProtocol/barretenberg#899 as ultimately we might want to have the ultra_ops and raw_ops only accessible and modifiable by funcitons.

maramihali · 2024-03-08T12:57:11Z

barretenberg/cpp/src/barretenberg/proof_system/op_queue/ecc_op_queue.hpp

@@ -34,7 +45,6 @@ class ECCOpQueue {
    size_t previous_ultra_ops_size = 0; // M_{i-1}

    std::array<Point, 4> ultra_ops_commitments;
-    std::array<Point, 4> previous_ultra_ops_commitments;


this is not used anywhere so removed

Rumata888 · 2024-03-08T12:59:39Z

...nberg/cpp/src/barretenberg/proof_system/circuit_builder/eccvm/eccvm_circuit_builder.test.cpp

@@ -240,32 +255,36 @@ TYPED_TEST(ECCVMCircuitBuilderTests, MSM)
    static constexpr size_t max_num_msms = 9;
    auto generators = G1::derive_generators("test generators", max_num_msms);

-    const auto try_msms = [&](const size_t num_msms, auto& circuit) {
+    const auto try_msms = [&](const size_t num_msms, auto& op_queue) {


why is it called "try_msms"?

good question, i guess it could be perform_msms

Rumata888 · 2024-03-08T13:03:37Z

barretenberg/cpp/src/barretenberg/proof_system/op_queue/ecc_op_queue.hpp

@@ -7,6 +7,17 @@ namespace bb {

 enum EccOpCode { NULL_OP, ADD_ACCUM, MUL_ACCUM, EQUALITY };

+struct UltraOpTuple {


It's slightly confusing, because it is not a tuple

I guess we have ECCVMOp and this should be just ECCOp?

I guess you previous suggestion for just naming it "UltraOp" is better

Rumata888 · 2024-03-08T13:04:16Z

barretenberg/cpp/src/barretenberg/proof_system/op_queue/ecc_op_queue.hpp

@@ -281,6 +283,19 @@ class ECCOpQueue {
            .mul_scalar_full = 0,
        });
    }
+
+    void populate_ultra_ops(UltraOpTuple tuple)


Why doesn't this update raw ops accordingly?

Also, there is no description

because ultra ops are populated in the circuit builder, if we'd want to populate the ultra ops and raw ops together it should be done in the ecc_op functionsthat operate on raw ops but that would be akward i think

AztecBot · 2024-03-08T13:49:46Z

Benchmark results

Metrics with a significant change:

batch_insert_into_append_only_tree_16_depth_ms (8): 16.6 (+34%)
batch_insert_into_append_only_tree_16_depth_hash_ms (8): 0.705 (+34%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit f3d9f9b5 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,700	18,884	36,452
l1_rollup_calldata_gas	66,528	239,516	470,348
l1_rollup_execution_gas	673,991	980,337	1,389,122
l2_block_processing_time_in_ms	1,194	4,481 (+3%)	8,860 (-1%)
note_successful_decrypting_time_in_ms	207 (-2%)	542 (+1%)	992
note_trial_decrypting_time_in_ms	13.4 (-27%)	61.9 (+12%)	132 (-1%)
l2_block_building_time_in_ms	12,041	47,601	95,744
l2_block_rollup_simulation_time_in_ms	7,314	29,096	58,955
l2_block_public_tx_process_time_in_ms	4,695	18,441	36,676

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,856 (-3%)	27,388 (+3%)
note_history_successful_decrypting_time_in_ms	1,211 (-3%)	2,403 (+1%)
note_history_trial_decrypting_time_in_ms	76.0 (-17%)	166 (+26%)
node_database_size_in_bytes	18,755,664	35,536,976
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	250 (-1%)	44,736	28,001
private-kernel-ordering	194	52,625	14,627
base-rollup	653 (-1%)	177,932	997
root-rollup	68.3 (-1%)	4,320	825
private-kernel-inner	316 (-1%)	73,715	28,001
public-kernel-app-logic	163 (-1%)	34,920	27,972
public-kernel-tail	81.1 (-1%)	34,507	27,972
merge-rollup	8.46	2,840	997

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.63 (-2%)	10.1 (-6%)	⚠️ 16.6 (+34%)	15.9 (-1%)	21.9 (+1%)	34.9	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	79.0	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.560 (-2%)	0.561 (-6%)	⚠️ 0.705 (+34%)	0.494 (-1%)	0.458 (+1%)	0.437	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	45.3 (-1%)	70.9 (-1%)	230	439 (-1%)	865 (+3%)	1,708
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	96.0	159	543	1,055	2,079	4,127
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.465 (-1%)	0.438 (-1%)	0.419	0.411 (-1%)	0.412 (+3%)	0.410
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	52.8 (-1%)	106	340	651 (-2%)	1,310 (+3%)	2,591
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	104	207	691	1,363	2,707	5,395
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.471 (-1%)	0.476	0.457 (-1%)	0.449 (-1%)	0.455 (+2%)	0.451
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	60.3 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	109	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	0.529 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts
tx_size_in_bytes	19,179

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,703	1,364 (-1%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	5.54 (+4%)	568 (-1%)

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.26.6</summary> ## [0.26.6](aztec-package-v0.26.5...aztec-package-v0.26.6) (2024-03-08) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.26.6</summary> ## [0.26.6](barretenberg.js-v0.26.5...barretenberg.js-v0.26.6) (2024-03-08) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.26.6</summary> ## [0.26.6](aztec-cli-v0.26.5...aztec-cli-v0.26.6) (2024-03-08) ### Features * Show bytecode size per function in CLI inspect-contract ([#5059](#5059)) ([cb9fdc6](cb9fdc6)) </details> <details><summary>aztec-packages: 0.26.6</summary> ## [0.26.6](aztec-packages-v0.26.5...aztec-packages-v0.26.6) (2024-03-08) ### Features * Basic public reverts ([#4870](#4870)) ([5cccc78](5cccc78)) * Deploying new inbox ([#5036](#5036)) ([fed729d](fed729d)) * Detect unknown note type ids in compute_note_hash ([#5086](#5086)) ([6206bec](6206bec)) * Easy deployment of protocol contracts in e2e ([#4983](#4983)) ([480161f](480161f)) * IPA documentation ([#4924](#4924)) ([48bd22e](48bd22e)) * Nullifier read requests in public kernel ([#4910](#4910)) ([0e44247](0e44247)) * Show bytecode size per function in CLI inspect-contract ([#5059](#5059)) ([cb9fdc6](cb9fdc6)) * Updating an SMT solver class ([#4981](#4981)) ([4b94d58](4b94d58)) ### Bug Fixes * Canonical contract address ([#5030](#5030)) ([b2af880](b2af880)) * Flaky deployment test ([#5035](#5035)) ([039eafc](039eafc)) * Pull the correct platform image for noir ([#5097](#5097)) ([3342371](3342371)) * Sleep function memory leak ([#5023](#5023)) ([a72cfea](a72cfea)), closes [#4817](#4817) * Storage v2 ([#5027](#5027)) ([fe3190e](fe3190e)) * Update protogalaxy cmake dependencies ([#5066](#5066)) ([507c374](507c374)) ### Miscellaneous * Address warnings in noir test suite ([#4966](#4966)) ([7ef4ef5](7ef4ef5)) * Bootstrap noir natively if nargo is invalid ([#5034](#5034)) ([df089de](df089de)) * Build avm transpiler if we are on mac ([#5039](#5039)) ([c2966b9](c2966b9)) * **ci:** Re-enable certain bb solidity ACIR tests ([#5065](#5065)) ([58e1ff4](58e1ff4)) * Cleanup of prover and verifier instances ([#4959](#4959)) ([f2fdefd](f2fdefd)) * Delete bootstrap scripts from `noir/noir-repo` ([#5044](#5044)) ([add91ca](add91ca)) * Disable `hello_world_example` noir test in aztec-packages CI ([#5061](#5061)) ([1be9243](1be9243)) * Join-split example Part 1 ([#4965](#4965)) ([b9de0f5](b9de0f5)) * Moving RootRollupInputs impl ([#5087](#5087)) ([f3d9f9b](f3d9f9b)) * Remove eccvm functionality to update the op queue and ensure ultra ops are populated through function ([#5084](#5084)) ([77954ab](77954ab)) ### Documentation * Parity circuit naming fixes ([#5076](#5076)) ([c255255](c255255)) </details> <details><summary>barretenberg: 0.26.6</summary> ## [0.26.6](barretenberg-v0.26.5...barretenberg-v0.26.6) (2024-03-08) ### Features * IPA documentation ([#4924](#4924)) ([48bd22e](48bd22e)) * Updating an SMT solver class ([#4981](#4981)) ([4b94d58](4b94d58)) ### Bug Fixes * Storage v2 ([#5027](#5027)) ([fe3190e](fe3190e)) * Update protogalaxy cmake dependencies ([#5066](#5066)) ([507c374](507c374)) ### Miscellaneous * **ci:** Re-enable certain bb solidity ACIR tests ([#5065](#5065)) ([58e1ff4](58e1ff4)) * Cleanup of prover and verifier instances ([#4959](#4959)) ([f2fdefd](f2fdefd)) * Join-split example Part 1 ([#4965](#4965)) ([b9de0f5](b9de0f5)) * Remove eccvm functionality to update the op queue and ensure ultra ops are populated through function ([#5084](#5084)) ([77954ab](77954ab)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.26.6</summary> ## [0.26.6](AztecProtocol/aztec-packages@aztec-package-v0.26.5...aztec-package-v0.26.6) (2024-03-08) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.26.6</summary> ## [0.26.6](AztecProtocol/aztec-packages@barretenberg.js-v0.26.5...barretenberg.js-v0.26.6) (2024-03-08) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.26.6</summary> ## [0.26.6](AztecProtocol/aztec-packages@aztec-cli-v0.26.5...aztec-cli-v0.26.6) (2024-03-08) ### Features * Show bytecode size per function in CLI inspect-contract ([#5059](AztecProtocol/aztec-packages#5059)) ([cb9fdc6](AztecProtocol/aztec-packages@cb9fdc6)) </details> <details><summary>aztec-packages: 0.26.6</summary> ## [0.26.6](AztecProtocol/aztec-packages@aztec-packages-v0.26.5...aztec-packages-v0.26.6) (2024-03-08) ### Features * Basic public reverts ([#4870](AztecProtocol/aztec-packages#4870)) ([5cccc78](AztecProtocol/aztec-packages@5cccc78)) * Deploying new inbox ([#5036](AztecProtocol/aztec-packages#5036)) ([fed729d](AztecProtocol/aztec-packages@fed729d)) * Detect unknown note type ids in compute_note_hash ([#5086](AztecProtocol/aztec-packages#5086)) ([6206bec](AztecProtocol/aztec-packages@6206bec)) * Easy deployment of protocol contracts in e2e ([#4983](AztecProtocol/aztec-packages#4983)) ([480161f](AztecProtocol/aztec-packages@480161f)) * IPA documentation ([#4924](AztecProtocol/aztec-packages#4924)) ([48bd22e](AztecProtocol/aztec-packages@48bd22e)) * Nullifier read requests in public kernel ([#4910](AztecProtocol/aztec-packages#4910)) ([0e44247](AztecProtocol/aztec-packages@0e44247)) * Show bytecode size per function in CLI inspect-contract ([#5059](AztecProtocol/aztec-packages#5059)) ([cb9fdc6](AztecProtocol/aztec-packages@cb9fdc6)) * Updating an SMT solver class ([#4981](AztecProtocol/aztec-packages#4981)) ([4b94d58](AztecProtocol/aztec-packages@4b94d58)) ### Bug Fixes * Canonical contract address ([#5030](AztecProtocol/aztec-packages#5030)) ([b2af880](AztecProtocol/aztec-packages@b2af880)) * Flaky deployment test ([#5035](AztecProtocol/aztec-packages#5035)) ([039eafc](AztecProtocol/aztec-packages@039eafc)) * Pull the correct platform image for noir ([#5097](AztecProtocol/aztec-packages#5097)) ([3342371](AztecProtocol/aztec-packages@3342371)) * Sleep function memory leak ([#5023](AztecProtocol/aztec-packages#5023)) ([a72cfea](AztecProtocol/aztec-packages@a72cfea)), closes [#4817](AztecProtocol/aztec-packages#4817) * Storage v2 ([#5027](AztecProtocol/aztec-packages#5027)) ([fe3190e](AztecProtocol/aztec-packages@fe3190e)) * Update protogalaxy cmake dependencies ([#5066](AztecProtocol/aztec-packages#5066)) ([507c374](AztecProtocol/aztec-packages@507c374)) ### Miscellaneous * Address warnings in noir test suite ([#4966](AztecProtocol/aztec-packages#4966)) ([7ef4ef5](AztecProtocol/aztec-packages@7ef4ef5)) * Bootstrap noir natively if nargo is invalid ([#5034](AztecProtocol/aztec-packages#5034)) ([df089de](AztecProtocol/aztec-packages@df089de)) * Build avm transpiler if we are on mac ([#5039](AztecProtocol/aztec-packages#5039)) ([c2966b9](AztecProtocol/aztec-packages@c2966b9)) * **ci:** Re-enable certain bb solidity ACIR tests ([#5065](AztecProtocol/aztec-packages#5065)) ([58e1ff4](AztecProtocol/aztec-packages@58e1ff4)) * Cleanup of prover and verifier instances ([#4959](AztecProtocol/aztec-packages#4959)) ([f2fdefd](AztecProtocol/aztec-packages@f2fdefd)) * Delete bootstrap scripts from `noir/noir-repo` ([#5044](AztecProtocol/aztec-packages#5044)) ([add91ca](AztecProtocol/aztec-packages@add91ca)) * Disable `hello_world_example` noir test in aztec-packages CI ([#5061](AztecProtocol/aztec-packages#5061)) ([1be9243](AztecProtocol/aztec-packages@1be9243)) * Join-split example Part 1 ([#4965](AztecProtocol/aztec-packages#4965)) ([b9de0f5](AztecProtocol/aztec-packages@b9de0f5)) * Moving RootRollupInputs impl ([#5087](AztecProtocol/aztec-packages#5087)) ([f3d9f9b](AztecProtocol/aztec-packages@f3d9f9b)) * Remove eccvm functionality to update the op queue and ensure ultra ops are populated through function ([#5084](AztecProtocol/aztec-packages#5084)) ([77954ab](AztecProtocol/aztec-packages@77954ab)) ### Documentation * Parity circuit naming fixes ([#5076](AztecProtocol/aztec-packages#5076)) ([c255255](AztecProtocol/aztec-packages@c255255)) </details> <details><summary>barretenberg: 0.26.6</summary> ## [0.26.6](AztecProtocol/aztec-packages@barretenberg-v0.26.5...barretenberg-v0.26.6) (2024-03-08) ### Features * IPA documentation ([#4924](AztecProtocol/aztec-packages#4924)) ([48bd22e](AztecProtocol/aztec-packages@48bd22e)) * Updating an SMT solver class ([#4981](AztecProtocol/aztec-packages#4981)) ([4b94d58](AztecProtocol/aztec-packages@4b94d58)) ### Bug Fixes * Storage v2 ([#5027](AztecProtocol/aztec-packages#5027)) ([fe3190e](AztecProtocol/aztec-packages@fe3190e)) * Update protogalaxy cmake dependencies ([#5066](AztecProtocol/aztec-packages#5066)) ([507c374](AztecProtocol/aztec-packages@507c374)) ### Miscellaneous * **ci:** Re-enable certain bb solidity ACIR tests ([#5065](AztecProtocol/aztec-packages#5065)) ([58e1ff4](AztecProtocol/aztec-packages@58e1ff4)) * Cleanup of prover and verifier instances ([#4959](AztecProtocol/aztec-packages#4959)) ([f2fdefd](AztecProtocol/aztec-packages@f2fdefd)) * Join-split example Part 1 ([#4965](AztecProtocol/aztec-packages#4965)) ([b9de0f5](AztecProtocol/aztec-packages@b9de0f5)) * Remove eccvm functionality to update the op queue and ensure ultra ops are populated through function ([#5084](AztecProtocol/aztec-packages#5084)) ([77954ab](AztecProtocol/aztec-packages@77954ab)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

maramihali added 2 commits March 7, 2024 15:24

remove functionality from eccvm that modifies the op queue

835383c

populate ultra ops only through function

0f792e3

maramihali changed the title ~~Mm/op queue refactor~~ refactor: remove eccvm functionality to update the op queue and ensure ultra ops are populated via API Mar 8, 2024

maramihali force-pushed the mm/op-queue-refactor branch from 175a26f to 0f792e3 Compare March 8, 2024 12:46

maramihali requested a review from Rumata888 March 8, 2024 12:49

maramihali self-assigned this Mar 8, 2024

maramihali added the crypto cryptography label Mar 8, 2024

maramihali marked this pull request as ready for review March 8, 2024 12:50

maramihali commented Mar 8, 2024

View reviewed changes

Merge branch 'master' into mm/op-queue-refactor

dadb74d

Rumata888 reviewed Mar 8, 2024

View reviewed changes

maramihali added 2 commits March 8, 2024 13:04

rename from review

33fc34c

remanimng and comment from review

504534c

maramihali requested a review from Rumata888 March 8, 2024 13:21

maramihali changed the title ~~refactor: remove eccvm functionality to update the op queue and ensure ultra ops are populated via API~~ refactor: remove eccvm functionality to update the op queue and ensure ultra ops are populated through function Mar 8, 2024

Rumata888 approved these changes Mar 8, 2024

View reviewed changes

maramihali enabled auto-merge (squash) March 8, 2024 14:53

Merge branch 'master' into mm/op-queue-refactor

af8421d

maramihali merged commit 77954ab into master Mar 8, 2024
91 of 92 checks passed

maramihali deleted the mm/op-queue-refactor branch March 8, 2024 15:16

AztecBot mentioned this pull request Mar 8, 2024

chore(master): Release 0.26.6 #5037

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: remove eccvm functionality to update the op queue and ensure ultra ops are populated through function #5084

refactor: remove eccvm functionality to update the op queue and ensure ultra ops are populated through function #5084

maramihali commented Mar 8, 2024 •

edited

Loading

maramihali Mar 8, 2024

Rumata888 Mar 8, 2024

maramihali Mar 8, 2024

maramihali Mar 8, 2024

Rumata888 Mar 8, 2024

maramihali Mar 8, 2024

Rumata888 Mar 8, 2024

Rumata888 Mar 8, 2024

Rumata888 Mar 8, 2024

maramihali Mar 8, 2024

AztecBot commented Mar 8, 2024 •

edited

Loading

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

		@@ -7,6 +7,17 @@ namespace bb {

		enum EccOpCode { NULL_OP, ADD_ACCUM, MUL_ACCUM, EQUALITY };

		struct UltraOpTuple {

refactor: remove eccvm functionality to update the op queue and ensure ultra ops are populated through function #5084

refactor: remove eccvm functionality to update the op queue and ensure ultra ops are populated through function #5084

Conversation

maramihali commented Mar 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AztecBot commented Mar 8, 2024 • edited Loading

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

maramihali commented Mar 8, 2024 •

edited

Loading

AztecBot commented Mar 8, 2024 •

edited

Loading