Rover: cycle through rangefinders when sending WATER_DEPTH #28877
+88
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and reduce the default rate this is currently unconditionally streamed at 50Hz, chewing up all available bandwidth on some telemetry radios.
only compiled in on Rover at the moment. need to add an additional Rover-specific check for frame type, so move this code into Rover for now.
only compiled in on Rover at the moment. need to add an additional Rover-specific check for frame type, so move this code into Rover for now.
peterbarker
force-pushed
the
pr/cycle-water-depth-sensors
branch
from
a5ab12d to
af87248
Compare
similarly to the way we do batteries, do not scale the amount of telemetry sent according to the number of backends we have.
peterbarker
force-pushed
the
pr/cycle-water-depth-sensors
branch
from
af87248 to
faa2839
Compare
|
New autotest fails before the patch, passes after: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested in #28875