Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCS_Common: fix send_sys_status() to send correct current #28820

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

magicrub
Copy link
Contributor

@magicrub magicrub commented Dec 6, 2024

Current behavior: If you have multiple batteries and ANY of them are unhealthy then the SYS_STATUS msg shows a current of -1A. All the other battery member functions have a default index == AP_BATT_PRIMARY_INSTANCE except healthy() which applies to all instances.

New behavior: battery index [AP_BATT_PRIMARY_INSTANCE] (usually 0) current is always shown for SYS_STATUS regardless of the state of other battery indexes

@magicrub magicrub added the BUG label Dec 6, 2024
@peterbarker
Copy link
Contributor

New behavior: battery index [AP_BATT_PRIMARY_INSTANCE] (usually 0) current is always shown for SYS_STATUS regardless of the state of other battery indexes

You haven't called out the change in behaviour of the healthy flag here. Did you also mean to change the meaning of that bit?

@magicrub
Copy link
Contributor Author

Yes, in fact that's the root cause of my problem. I had multiple batteries (mppts and payload sensors) and if ANY of them were unhealthy then the main battery would report 0.0A.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants