AC_Autotune: Fix bug introduced in #27370 #27762
Merged
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
approved these changes
Aug 6, 2024
|
I've marked this as MergeOnCIPass because this bug results in the vehicle's max accelerations being set to 4000 which is dangerously low. @lthall is confident this change is correct and it looks OK to me as well |
tpwrules
added a commit
to tpwrules/ardupilot
that referenced
this pull request
Dec 4, 2024
Issue introduced in ArduPilot#27370 and partially fixed in ArduPilot#27762, though evidently not properly tested. Failing to track the maximum can result in a dangerously low value being calculated and the vehicle being unflyable. Make the variable a reference so that the maximum value is preserved between function calls.
tpwrules
added a commit
to tpwrules/ardupilot
that referenced
this pull request
Dec 4, 2024
Issue introduced in ArduPilot#27370 and partially fixed in ArduPilot#27762, though evidently not properly tested. Failing to track the maximum can result in dangerously low values being calculated for `ATC_ACCEL_[RPY]_MAX` and the vehicle becoming unflyable. Make the variable a reference so that the maximum value is preserved between function calls.
rmackay9
pushed a commit
that referenced
this pull request
Dec 5, 2024
Issue introduced in #27370 and partially fixed in #27762, though evidently not properly tested. Failing to track the maximum can result in dangerously low values being calculated for `ATC_ACCEL_[RPY]_MAX` and the vehicle becoming unflyable. Make the variable a reference so that the maximum value is preserved between function calls.
andyp1per
pushed a commit
to andyp1per/ardupilot
that referenced
this pull request
Dec 7, 2024
Issue introduced in ArduPilot#27370 and partially fixed in ArduPilot#27762, though evidently not properly tested. Failing to track the maximum can result in dangerously low values being calculated for `ATC_ACCEL_[RPY]_MAX` and the vehicle becoming unflyable. Make the variable a reference so that the maximum value is preserved between function calls.
andyp1per
pushed a commit
to andyp1per/ardupilot
that referenced
this pull request
Dec 7, 2024
Issue introduced in ArduPilot#27370 and partially fixed in ArduPilot#27762, though evidently not properly tested. Failing to track the maximum can result in dangerously low values being calculated for `ATC_ACCEL_[RPY]_MAX` and the vehicle becoming unflyable. Make the variable a reference so that the maximum value is preserved between function calls.
tridge
pushed a commit
to tridge/ardupilot
that referenced
this pull request
Dec 11, 2024
Issue introduced in ArduPilot#27370 and partially fixed in ArduPilot#27762, though evidently not properly tested. Failing to track the maximum can result in dangerously low values being calculated for `ATC_ACCEL_[RPY]_MAX` and the vehicle becoming unflyable. Make the variable a reference so that the maximum value is preserved between function calls.
tridge
pushed a commit
that referenced
this pull request
Dec 12, 2024
Issue introduced in #27370 and partially fixed in #27762, though evidently not properly tested. Failing to track the maximum can result in dangerously low values being calculated for `ATC_ACCEL_[RPY]_MAX` and the vehicle becoming unflyable. Make the variable a reference so that the maximum value is preserved between function calls.
Yury-MonZon
pushed a commit
to Yury-MonZon/ardupilot
that referenced
this pull request
Dec 12, 2024
Issue introduced in ArduPilot#27370 and partially fixed in ArduPilot#27762, though evidently not properly tested. Failing to track the maximum can result in dangerously low values being calculated for `ATC_ACCEL_[RPY]_MAX` and the vehicle becoming unflyable. Make the variable a reference so that the maximum value is preserved between function calls.
Yury-MonZon
pushed a commit
to Yury-MonZon/ardupilot
that referenced
this pull request
Dec 12, 2024
Issue introduced in ArduPilot#27370 and partially fixed in ArduPilot#27762, though evidently not properly tested. Failing to track the maximum can result in dangerously low values being calculated for `ATC_ACCEL_[RPY]_MAX` and the vehicle becoming unflyable. Make the variable a reference so that the maximum value is preserved between function calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the clean up to try to make things easer to understand due to poorly named variables, one of those variables was deleted and another similarly named variable used in it's place.
This fixes this problem.