Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move serial port configuration into user of serial ports #25097

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

peterbarker
Copy link
Contributor

This moves the serial port configuration into the libraries which are supposed to know how the protocol works.

We did this with many protocols, but these ones (and several more) change the baud rate to a fixed value so a user will see the expected baudrate when they download parameters. This PR adds a call onto the serial manager library to allow that to happen.

Board               AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
Durandal                       88     *           200     104               144    152    144
HerePro             -112                                                                  
Hitec-Airspeed      -112                                                                  
KakuteH7-bdshot                72     *           80      120               112    120    104
MatekF405                      -8     *           24      16                16     24     16
Pixhawk1-1M-bdshot             -16                -16     -16               -16    -16    -16
f103-QiotekPeriph   -112                                                                  
f303-Universal      -112                                                                  
iomcu                                                           *                         
revo-mini                      -16    *           24      16                16     16     24
skyviper-v2450                                    -16                                     

Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the mount changes at least.

Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has potential issues:

  • it means we begin() twice, first with wrong baudrate, could consume corrupted bytes
  • could impact memory allocation for uarts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants