Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_RTC: allow time to shift forward when disarmed #24022

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

peterbarker
Copy link
Contributor

No description provided.

@peterbarker
Copy link
Contributor Author

... the sanity check for no-backwards-times is further down in the function.

@tridge
Copy link
Contributor

tridge commented Jun 20, 2023

we will add drift logic, @davidbuzz or @Hwurzburg will test with F765 wing or Mambaf405v2
we need drift for fwd and backward drift

@davidbuzz
Copy link
Collaborator

for that clock drift issue... i connected a ublox to my f765-wing, formatted the sd card, then set:
LOG_DISARMED=1
LOG_REPLAY=1
.. then stick it outside for an hr ?
[ I have just done that]

@davidbuzz
Copy link
Collaborator

@davidbuzz
Copy link
Collaborator

side note, this log also has an internal error in it, possibly storage related.?

Storage: failed at 0:4154 for 8 - re-init 1
AP: Internal Errors 0x8000
... and a bit later
PreArm: Internal errors 0x8000 l:443 main_loop_stk

got this log on a normal f765-wing on the ground, logging while disarmed, with the only hardware connected is a gps , power ,and a usb cable.

AP: ArduPlane V4.5.0-dev (7234ec2)
AP: ChibiOS: a287e67d
AP: MatekF765-Wing 0031002A 34385105 34313531 (edited)

[ ie a recent 'latest' build from the autotest build server from the last week or 2?]

@davidbuzz
Copy link
Collaborator

davidbuzz commented Jun 20, 2023

re-ran test, and at about 1/2hr, the internal error came again..
Critical failure 0x8000 sysid=1 compid=1
AP: PreArm: Internal errors 0x8000 l:443 main_loop_stk
[this time i did not get a 'Storage: failed at xxx' ] that i saw.
the file named 222.bin at https://drive.google.com/file/d/17zTj43ID5CasyDOQSdevSlBo51P1eR75/view?usp=drive_link

@davidbuzz
Copy link
Collaborator

davidbuzz commented Jun 20, 2023

testing with a different SD card done... does not Internal Error with different SD card after an hr.
https://drive.google.com/file/d/10xtP3R3KByDtDLcHPNViJ_A2IjJKrIL0/view?usp=drive_link

@tridge tridge force-pushed the pr/reset-rtc-when-disarmed branch from 19a0bb6 to 789df02 Compare November 18, 2024 21:41
@tridge tridge mentioned this pull request Nov 18, 2024
22 tasks
libraries/AP_RTC/AP_RTC.cpp Show resolved Hide resolved
@tridge
Copy link
Contributor

tridge commented Nov 18, 2024

add log of 64 bit UTC time in STAT

@peterbarker peterbarker force-pushed the pr/reset-rtc-when-disarmed branch from 789df02 to 0dd9c4a Compare November 19, 2024 01:17
@peterbarker
Copy link
Contributor Author

This is an autopilot getting a GPS fix:
image

@peterbarker
Copy link
Contributor Author

add log of 64 bit UTC time in STAT

Had to go with PM instead - STAT is actually a Plane-specific message to do with is-flying huristics for the most part.... I keep forgetting that.

@peterbarker peterbarker force-pushed the pr/reset-rtc-when-disarmed branch from 0dd9c4a to b8c342e Compare November 20, 2024 22:18
@tridge tridge merged commit 5647141 into ArduPilot:master Nov 20, 2024
81 checks passed
@peterbarker
Copy link
Contributor Author

This broke the documentation. Fixed here: #28695

@peterbarker peterbarker deleted the pr/reset-rtc-when-disarmed branch November 21, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 4.6.0-beta2
Development

Successfully merging this pull request may close these issues.

4 participants