-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConfigRawParams: When setting a parameter changes the number of parameters, do a full refresh. and check if reboot is needed #3271
Conversation
THANKS! I see the build artifact but not sure how to run it locally for some testing....its an aab file? |
param refresh dangerous when armed, as low bandwidth or long range links can be adversely affected - i support it if its tweaked to only do this when disarmed. |
PeterH suggested that we should only do the full refresh when the vehicle is disarmed. |
Indeed, added check for armed state. |
@EosBandi will try to reproduce...I was just randomly enablilng/changing parameters that I know need reboots |
If a param change causing the change in the number of parameters, the parameter subsystem could stuck in a "downloading is in progress" state. This pr:
removes the name check, since not only _enable parameters can change the number of parameters
Add a check at the end of Write Params and if the reported param number not equals with the current number, it notify the user and do a param refresh.
This fixes #3198