Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param loading Green line does not go away #3198

Closed
rmackay9 opened this issue Oct 3, 2023 · 5 comments · Fixed by #3271
Closed

Param loading Green line does not go away #3198

rmackay9 opened this issue Oct 3, 2023 · 5 comments · Fixed by #3271
Assignees

Comments

@rmackay9
Copy link
Contributor

rmackay9 commented Oct 3, 2023

I think there may be an issue with the latest beta which means that the green parameter bar never goes away.

image

I can push the Config Retry button but still the bar remains.
image

@rmackay9
Copy link
Contributor Author

It seems the "Retry Now" button appears every time a parameter is changed.

@EosBandi
Copy link
Collaborator

EosBandi commented Jan 6, 2024

Is it still happens with 1.3.81 ? I cannot repro it.

@EosBandi EosBandi self-assigned this Jan 6, 2024
@rmackay9
Copy link
Contributor Author

rmackay9 commented Jan 6, 2024

Hi @EosBandi,

Thanks for looking into this. the exact way that I can reproduce this is to:

  1. Start MP's copter simulator with "wipe" checked
  2. Open config, Full Parameter list and set MNT1_TYPE = 10 (Xacti)

.. the green line should appear but never go away.

@EosBandi
Copy link
Collaborator

EosBandi commented Jan 6, 2024

OK, got it. It seems to be a generic issue, when setting a parameter changes the number of parameters.
The quickest way to solve it to notify the user and do a forced parameter refresh.

Can you imagine a scenario when this forced refresh can cause an issue ?

@rmackay9
Copy link
Contributor Author

rmackay9 commented Jan 6, 2024

Thanks very much for that fix!

On very slow links downloading all parameters could be very slow and could even timeout. That's the only real problem I think. I don't think the autopilot's performance (e.g. the main loop) will slow down during a parameter download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants