feat(vbank): new param allowed_monitoring_accounts
#10488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
changed the title
allowed_monitoring_accounts
michaelfig
force-pushed
the
mfig-vbank-monitoring-config
branch
from
e5a3f22 to
4809689
Compare
Deploying agoric-sdk with
|
| Latest commit: |
8bd1d0b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4cf43738.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mfig-vbank-monitoring-config.agoric-sdk.pages.dev |
michaelfig
force-pushed
the
mfig-vbank-monitoring-config
branch
from
4809689 to
70f8bb5
Compare
michaelfig
force-pushed
the
mfig-vbank-monitoring-config
branch
3 times, most recently
from
c04e5c6 to
814a45d
Compare
JeancarloBarrios
approved these changes
Nov 18, 2024
michaelfig
force-pushed
the
mfig-vbank-monitoring-config
branch
from
814a45d to
ef6e7e0
Compare
michaelfig
added
the
automerge:no-update
michaelfig
force-pushed
the
mfig-vbank-monitoring-config
branch
from
ef6e7e0 to
b31cb4f
Compare
michaelfig
force-pushed
the
mfig-vbank-monitoring-config
branch
from
b31cb4f to
8bd1d0b
Compare
michaelfig
force-pushed
the
mfig-vbank-monitoring-config
branch
from
8bd1d0b to
0e367d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8564
Description
To make the Golang
x/vbankmore flexible, introduce anallowed_monitoring_accountsparameter. The default at agd genesis, or when an existing chain does a software-upgrade to this agd, will prevent balance monitoring except to thevbank/provisionmodule account ("agoric1megzytg65cyrgzs6fvzxgrcqvwwl7ugpt62346", according topackages/internal/src/config.js). This provisioning account's balances need to be monitored for normal operation ofpackages/inter-protocol/src/provisionPoolKit.js.This restriction will prevent the cause of #8564 (that the vast majority of balance monitoring updates were to the
vbank/reservemodule account, which did nothing with them), while making it possible to reënable balance updates when they can be reworked and deemed harmless.Security Considerations
n/a
Scaling Considerations
Improves scalability if the chain is dealing with Cosmos x/bank sends (which are also triggered by IBC transfers) among many different accounts.
Documentation Considerations
n/a
Testing Considerations
The
"*"wildcard-all short-circuit is not tested yet.Upgrade Considerations
No JS changes, and preserving backward compatibility in the bridge messages, so this should be safe to upgrade.