Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

~300k vbank balance updates mostly wasted #8564

Closed
dckc opened this issue Nov 27, 2023 · 1 comment · Fixed by #10488
Closed

~300k vbank balance updates mostly wasted #8564

dckc opened this issue Nov 27, 2023 · 1 comment · Fixed by #10488
Assignees
Labels
cosmic-swingset package: cosmic-swingset enhancement New feature or request needs-design performance Performance related issues triaged_2024

Comments

@dckc
Copy link
Member

dckc commented Nov 27, 2023

What is the Problem Being Solved?

In #7473 / #5896 , we eliminated all vpurse balance updates except module accounts, since the provision pool subscribes to an ERTP balance notifier for its module account.

Unfortunately, there are still a lot of useless module account updates. For example,
@michaelfig notes that every cosmos transaction fee causes a balance update of the agoric1...h3nucl fee module account (aka reserve). I'm not aware of any JS code that's listening for those.

@warner did some analysis of mainnet swingset work up to the agoric-upgrade-12 halt and found 311k VBANK_BALANCE_UPDATE events, including:

address count
agoric1ae0lmtzlgrcnla9xjkpaarq5d5dfez63h3nucl 298,770

Description of the Design

?

Security Considerations

could become an availability risk at some point

Scaling Considerations

yes :)

Test Plan

?

Upgrade Considerations

?

@dckc dckc added enhancement New feature or request cosmic-swingset package: cosmic-swingset performance Performance related issues needs-design labels Nov 27, 2023
@dckc
Copy link
Member Author

dckc commented Nov 27, 2023

I asked @warner about impact...

Relatively low, mean 17ms / 127kc (computrons) each. So we do 500 before we fill a block, and could do 100 before making the compute time be significant. It adds to the growth rate of DBs, so I'd like to reduce it, but the actual CPU cost is not huge at the current rate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmic-swingset package: cosmic-swingset enhancement New feature or request needs-design performance Performance related issues triaged_2024
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants