Add a gdk-pixbuf module #182
Conversation
linkmauve
force-pushed
the
gdk-pixbuf
branch
2 times, most recently
from
c3f56ef to
d5ea7ed
Compare
|
Assuming you can survive the Travis (and other) CI checks, I'm generally okay with this kind of thing. That said, this is the kind of thing that should be in a I'll probably want all contrib build options to be in their own section in CMakeLists.txt, but I can clean that up afterwards. |
|
I'll make a stub |
|
I can commit to becoming the maintainer of this loader, if that’s what you’re worried about. :) As for the license, I went with the same one as libavif, as I don’t have much of a preference. With gdk-pixbuf itself being under LGPL 2.1, that shouldn’t be an issue. I’ll rearrange the cmake stuff and move it there, fix the const issues from clang, and then this MVP should be good to go, thanks! |
linkmauve
force-pushed
the
gdk-pixbuf
branch
2 times, most recently
from
16494e9 to
0139a2a
Compare
|
I recognize that you might simply have it on right now to verify the build with CI, but |
|
There, CI passed! Edit: I’ve pushed a new version where it isn’t built by default anymore, thanks! |
gdk-pixbuf[1] is a widely-used image loader on Linux, this module gives most Linux software instant support for AVIF. gdk-pixbuf upstream rejects any new format[2], so in order to make Linux distributions aware that this AVIF loader exists it makes sense to ship it alongside libavif. For now it only supports loading still images (no sequences) and doesn’t support saving, but this can come in a later pull request. [1] https://developer.gnome.org/gdk-pixbuf/stable/ [2] https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/merge_requests/76#note_845043
|
I've merged this, but I'm going to move the CMake block into the contrib subdir. Let me know if it breaks for you after I've done this, please. |
|
Alright, I've moved the block here (with one tiny change to the sources line): I've also put your own license header at the top, as you're the author of that block. This layout is much easier to delineate licensing and scales better if others offer future contributions. |
|
I confirm it still works when adding |
AOMediaCodec/libavif#182 AOMediaCodec/libavif#977 Mostly mirrors webp-pixbuf-loader. Also use prefixed names for `loaders.cache` so that users can install multiple loaders in a profile without collisions, and move `bin/webp-thumbnailer` to `libexec/gdk-pixbuf-thumbnailer-webp` (and similarly for avif).
gdk-pixbuf is a widely-used image loader on Linux, this module gives most Linux software instant support for AVIF.
gdk-pixbuf upstream rejects any new format, so in order to make Linux distributions aware that this AVIF loader exists it makes sense to ship it alongside libavif.
For now it only supports loading still images (no sequences) and doesn’t support saving, but this can come in a later pull request.