Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GdkPixbuf based thumbnailer #977

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented Jun 28, 2022

Also build the lib as module instead of shared - the import library is not needed on Windows for GdkPixbuf loaders.

@wantehchang wantehchang merged commit 7ad6f48 into AOMediaCodec:main Jul 6, 2022
@kmilos kmilos deleted the patch-1 branch July 6, 2022 08:29
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. (I forgot to mark this pull request Approved before merging it.)

ncfavier pushed a commit to ncfavier/nixpkgs that referenced this pull request Jul 25, 2023
AOMediaCodec/libavif#182
AOMediaCodec/libavif#977

Mostly mirrors webp-pixbuf-loader.

Also use prefixed names for `loaders.cache` so that users can install
multiple loaders in a profile without collisions, and move
`bin/webp-thumbnailer` to `libexec/gdk-pixbuf-thumbnailer-webp` (and
similarly for avif).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants