Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(network): automatic Antenna Criteria check #2036

Merged
merged 39 commits into from
Sep 15, 2024
Merged

feat(network): automatic Antenna Criteria check #2036

merged 39 commits into from
Sep 15, 2024

Conversation

LeonVreling
Copy link
Member

No description provided.

@LeonVreling LeonVreling requested a review from WikiRik January 28, 2024 16:05
@LeonVreling LeonVreling changed the title feat(network): Add a first draft for automatic AC check of events feat(network): Add a first draft for automatic Antenna Criteria check Feb 24, 2024
@LeonVreling LeonVreling mentioned this pull request Feb 24, 2024
Merged
@LeonVreling LeonVreling mentioned this pull request Feb 25, 2024
Merged
@LeonVreling LeonVreling changed the title feat(network): Add a first draft for automatic Antenna Criteria check feat(network): Automatic Antenna Criteria check Aug 15, 2024
@LeonVreling LeonVreling marked this pull request as ready for review August 15, 2024 14:05
@LeonVreling LeonVreling requested a review from WikiRik August 15, 2024 14:06
LeonVreling and others added 2 commits August 15, 2024 16:06
@LeonVreling
Merge branch 'stable' into ac-check
c4cac1f
@LeonVreling
fix(network): Fix copy paste error
418b7f7 
NetCom should no longer be allowed to give exceptions to `communication`
@LeonVreling LeonVreling mentioned this pull request Aug 15, 2024
Merged
@LeonVreling
Copy link
Member Author

@WikiRik I just saw there are still two TODO's in the code for the checking of the Events criterion, but I think it would still be good to have a review since the list of changes is quite long 😁

@WikiRik
Copy link
Member

WikiRik commented Aug 15, 2024

Yes, I think a review is good to do. I should be able to work on that this weekend

This was referenced Aug 15, 2024
Merged
Merged
@WikiRik
Copy link
Member

WikiRik commented Aug 18, 2024 •
edited
Loading

@LeonVreling can you make a PR in core for the new permissions (and the other permissions added in network earlier) and NetCom/ND/FD users? https://github.com/AEGEE/core/blob/stable/scripts/seed.js

WikiRik
WikiRik reviewed Aug 18, 2024
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to take some time to review the backend PRs first and then set up more data to test with before I review this further

This is what I see if I only have the NetCom permissions created (and all that is in the core seeder), is that correct?
image

src/router/routes.js Outdated Show resolved Hide resolved
src/views/network/AntennaCriteriaCheck.vue Show resolved Hide resolved
@LeonVreling
Copy link
Member Author

@LeonVreling can you make a PR in core for the new permissions (and the other permissions added in network earlier) and NetCom/ND/FD users? https://github.com/AEGEE/core/blob/stable/scripts/seed.js

The pull request for core can be found at AEGEE/core#972

LeonVreling and others added 2 commits September 15, 2024 19:55
@LeonVreling
chore(network): Add back reload after modal submission
f4214ae 
I commented this out for easier local testing, but it should be part of the final release for consistency with the rest of the project
@WikiRik
Merge branch 'stable' into ac-check
683ae8c
WikiRik
WikiRik approved these changes Sep 15, 2024
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't deploy this until AEGEE/network#599 is merged, but this looks good

@WikiRik WikiRik changed the title feat(network): Automatic Antenna Criteria check feat(network): automatic Antenna Criteria check Sep 15, 2024
@WikiRik WikiRik merged commit 94219f0 into stable Sep 15, 2024
4 checks passed
@WikiRik WikiRik deleted the ac-check branch September 15, 2024 18:42
serge1peshcoff pushed a commit that referenced this pull request Sep 15, 2024
@semantic-release-bot
chore(release): 1.37.0 [skip ci]
a56a75a 
# [1.37.0](1.36.1...1.37.0) (2024-09-15)

### Features

* **network:** automatic Antenna Criteria check ([#2036](#2036)) ([94219f0](94219f0))
@serge1peshcoff
Copy link
Member

🎉 This PR is included in version 1.37.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik WikiRik approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeonVreling @WikiRik @serge1peshcoff