Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AC check): Add endpoint to get most recent event of a body #1074

Merged
merged 12 commits into from
Aug 19, 2024

Conversation

LeonVreling
Copy link
Member

@LeonVreling LeonVreling commented Jan 28, 2024

Needed for functioning of AEGEE/frontend#2036

@LeonVreling LeonVreling requested a review from WikiRik January 28, 2024 16:04
@WikiRik
Copy link
Member

WikiRik commented Feb 17, 2024

Before I forget; we do not know right now which events count for the Antenna Criteria (and even that changes depending on if you want to upgrade to an antenna or want to remain an antenna)

Upgrade to an antenna; "Have organised a European event, AEGEE event or AEGEE-Europe event according to
the Event Rules in the past two years."
Remaining an antenna; "Have organised a European event or Summer University at least once every two years."

@WikiRik
Copy link
Member

WikiRik commented Feb 24, 2024

In general I'm okay with merging this (after a positive review), but it cannot be used as AC check yet. The new proposal from EQAC et al also excludes some events mentioned on MyAEGEE to count as fulfilling AC. Maybe we should add an additional field and check for the most recent one of that instead

@LeonVreling
Copy link
Member Author

Yes agreed, this will most likely need to change if the EQAC proposal is accepted (which would also be good for the implementation, since then the criteria are merged that you mentioned above)

@WikiRik
Copy link
Member

WikiRik commented Feb 25, 2024

If I read the draft correctly, the new proposal still does not mention that all MyAEGEE events (that fall under this microservice) are eligible for the AC. So we still need some additional logic here I think. Easiest is to add a checkbox mentioning that it counts as European Event. But do note that as definitions change, we will have more logic there so that's going to be fun

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.47%. Comparing base (130897f) to head (fdc95f7).
Report is 2 commits behind head on stable.

Additional details and impacted files
@@           Coverage Diff           @@
##           stable    #1074   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          18       18           
  Lines         757      764    +7     
  Branches      177      178    +1     
=======================================
+ Hits          753      760    +7     
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeonVreling
Copy link
Member Author

@WikiRik I believe all events from this microservice are now eligible, could you please check

@LeonVreling LeonVreling merged commit 3cc469a into stable Aug 19, 2024
7 checks passed
@LeonVreling LeonVreling deleted the events-ac-check branch August 19, 2024 16:37
serge1peshcoff pushed a commit that referenced this pull request Aug 19, 2024
# [1.5.0](1.4.2...1.5.0) (2024-08-19)

### Features

* **AC check:** Add endpoint to get most recent events of a body ([#1074](#1074)) ([3cc469a](3cc469a))
@serge1peshcoff
Copy link
Member

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants