-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AC check): Add endpoint to get most recent event of a body #1074
Conversation
Before I forget; we do not know right now which events count for the Antenna Criteria (and even that changes depending on if you want to upgrade to an antenna or want to remain an antenna) Upgrade to an antenna; "Have organised a European event, AEGEE event or AEGEE-Europe event according to |
In general I'm okay with merging this (after a positive review), but it cannot be used as AC check yet. The new proposal from EQAC et al also excludes some events mentioned on MyAEGEE to count as fulfilling AC. Maybe we should add an additional field and check for the most recent one of that instead |
Yes agreed, this will most likely need to change if the EQAC proposal is accepted (which would also be good for the implementation, since then the criteria are merged that you mentioned above) |
If I read the draft correctly, the new proposal still does not mention that all MyAEGEE events (that fall under this microservice) are eligible for the AC. So we still need some additional logic here I think. Easiest is to add a checkbox mentioning that it counts as European Event. But do note that as definitions change, we will have more logic there so that's going to be fun |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stable #1074 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 18 18
Lines 757 764 +7
Branches 177 178 +1
=======================================
+ Hits 753 760 +7
Misses 4 4 ☔ View full report in Codecov by Sentry. |
@WikiRik I believe all events from this microservice are now eligible, could you please check |
# [1.5.0](1.4.2...1.5.0) (2024-08-19) ### Features * **AC check:** Add endpoint to get most recent events of a body ([#1074](#1074)) ([3cc469a](3cc469a))
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Needed for functioning of AEGEE/frontend#2036