Handle write errors in ServerDeathTest #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We think this fixes #274 which we think is caused by the client attempting to write a request after the server has already exited. This commit ensures that `call.Finish()` is called whether or not the client's write succeeds.
|
Waiting for approval before queuing |
benh
approved these changes
Apr 18, 2022
MergeQueue statusMergeQueue will automatically update this comment as the status of the PR changes. This PR was merged using MergeQueue. |
|
Branch up-to-date, waiting for checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We think this fixes #274 which we think is caused by the client
attempting to write a request after the server has already exited.
This commit ensures that
call.Finish()is called whether or not theclient's write succeeds.