-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventualsGrpcTest.ServerDeathTest
is flaky
#274
Comments
3rdparty/eventuals-grpc#51 might have some historical context (though it might also be a different issue with a similar symptom) |
Anecdotally, this seems to be happening regularly on |
CodingCanuck
added a commit
that referenced
this issue
Apr 11, 2022
I'm hoping this should resolve the flaky failures seen in #274. At the very least, using subprocesses instead of threads, making process lifetime explicit (rather than relying on gtest's death test infrastructure), and ensuring that an RPC succeeds before terminating the server should make failures easier to debug. Should fix #274.
CodingCanuck
added a commit
that referenced
this issue
Apr 11, 2022
I'm hoping this should resolve the flaky failures seen in #274. At the very least, using subprocesses instead of threads, making process lifetime explicit (rather than relying on gtest's death test infrastructure), and ensuring that an RPC succeeds before terminating the server should make failures easier to debug. Should fix #274.
CodingCanuck
added a commit
that referenced
this issue
Apr 11, 2022
I'm hoping this should resolve the flaky failures seen in #274. At the very least, using subprocesses instead of threads, making process lifetime explicit (rather than relying on gtest's death test infrastructure), and ensuring that an RPC succeeds before terminating the server should make failures easier to debug. Should fix #274.
CodingCanuck
added a commit
that referenced
this issue
Apr 11, 2022
I'm hoping this should resolve the flaky failures seen in #274. At the very least, using subprocesses instead of threads, making process lifetime explicit (rather than relying on gtest's death test infrastructure), and ensuring that an RPC succeeds before terminating the server should make failures easier to debug. Should fix #274.
CodingCanuck
added a commit
that referenced
this issue
Apr 18, 2022
We think this fixes #274 which we think is caused by the client attempting to write a request after the server has already exited. This commit ensures that `call.Finish()` is called whether or not the client's write succeeds.
aviator-app bot
pushed a commit
that referenced
this issue
Apr 18, 2022
We think this fixes #274 which we think is caused by the client attempting to write a request after the server has already exited. This commit ensures that `call.Finish()` is called whether or not the client's write succeeds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sample flaky failure: https://github.com/3rdparty/eventuals/runs/5727035543?check_suite_focus=true
I'm not sure if the
failed to write
error is related to the warning aboutfork()
, but I wonder:The text was updated successfully, but these errors were encountered: