Deploy RC 319 to prod #9302
Merged
Deploy RC 319 to prod #9302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* commit * Separate auth app selections configurations * break up mfa presenters * changelog: Internal, Authentication, Refactor presenter logic to separate sign in and set up * rubocop * auth app selection * remove authentication app slection presenter * remove association with selection presenter * add end * make sure to include disabled? * add rspec for sign in auth app spec
[skip changelog]
changelog: Internal, Background Jobs, Queue KMS Migration Jobs as long running
Most of our rate limiting allows a user 5 attempts so this brings the entering of the GPO verification code in line with the others. We spoke to security and confirmed that there is no issue with this change. changelog: User-facing Improvements, Identity Verification By Mail, Increased user's max attempts to enter their verification code before being rate limited. Co-authored-by: Sonia Connolly <[email protected]>
changelog: Internal, Reporting, Manage recipients by config
* Try overriding Propshaft digesting for shorter file names changelog: Internal, Performance, Reduce size of bundled assets * Require monkeypatch by load path * Reference original implementation directly * Add explaining comment for monkeypatch * Revert "Reference original implementation directly" This reverts commit e8fe2d8. * Align hash size to JS assets Also cleaner math on bit-size of hash
* Upgrade Prettier to v3 changelog: Internal, Dependencies, Update dependencies to latest versions * Update normalize specs * Use consistent syntax for version ranges * Upgrade stylelint-prettier * Update yarn.lock
* Add FullAddressSearchProps to types.d.ts * Rename interfact, alpha order args * Add resultsHeaderComponent arg, alpha order * fix linter errors * increase version of identity-address-search * clean up duplicate interface * update data type and tests * delete unused var * changelog: Upcoming Features, In-person proofing, Add new optional resultsHeaderComponent prop onto FullAddressSearch so it can be passed in from help center * change data type * Move FullAddressSearchInputProps to types.d * Added logic to show/hide header and info text * moved props back inside component * Add show/hide logic to AddressSearch * fix linter errors * change prop type * change data type * update test * lint fix * add tests for address-search * fix linter errors
changelog: Internal, Performance, Reduce size of application stylesheet
Currently the ProfileMigrationJob and UserMigrationJob make expensive queries to find users to migrate. These queries need a large amount of time to run. To enable this we run them in a transaction with a local statement timeout. I discovered an issue with this approach. The query was not actually executed in the transaction block. The transaction returned a relation and the query was executed when we attempted to iterated over the records in the relation. This commit adds a `#to_a` call to the relation to ensure the query is run and the records are loaded into memory before the transaction block is complete. [skip changelog]
* init page if user has a phone to take pictures for A/B testing * changelog: Upcoming Features, Document Authentication, IdV page to ask user if they have a phone that can take photos * add french and spanish translations * rename smart_phone to phone_question page * add feature tests for phone question page * happy linting * remove future test stubbing * add skip phone_question step if on mobile * updated phone_question page translations as per LG-11079 and LG-11078 * happy linting * move confirm_hybrid_handoff_needed into idv step concern * add spec for cancel button on phone_question page * trigger CI * fix controller specs post hybrid_handoff_cofirm_needed move to idv step concern
* Add draft of phone question a_b variable * Change naming * changelog: Internal, In-Person Proofing, add variable for phone question A/B test * Remove redundant key/value in a/b config * Add variable to IdentityConfig * Lint fixes
* First crack at cleanup of "Request another letter?" screen No translations yet * Update RequestLetterPresenter spec * Update gpo_step_spec.rb * Update i18n references in specs * Update translations * Add back translations that are still used * changelog: User-Facing Improvements, Identity verification, Simplify and clarify 'request another letter' screen * Update vertical margin around button * Update config/locales/idv/fr.yml Co-authored-by: Sonia Connolly <[email protected]> * Update config/locales/idv/en.yml Co-authored-by: Sonia Connolly <[email protected]> * Update config/locales/idv/es.yml Co-authored-by: Sonia Connolly <[email protected]> * Normalize YAML --------- Co-authored-by: Sonia Connolly <[email protected]>
* Force refresh the page on third image permission denied * Remove any confirmation dialogs from the navigation * Fix test by adding keys * changelog: User-Facing Improvements, In-Person Proofing, Mitigate bug that occurs when denying Acuant permissions more than three times
* changelog: Bug Fixes, Signup, Add Backup Codes remembers browser * revoke remember device when regenerate codes * shorten configurations check to 1 liner * separate into with/without revoking device remember
* changelog: Internal, Doc Auth, Log error message when error message displayed Technical notes: - currently there will probably only be one general or one pii error message. But in the off chance that that changes in the future, we wanted to account for that with the `join`.
* Delete refs to 'idv/doc_auth' session changelog: Internal, Identity Verification code cleanup, delete final remnants of remote flow_session * Remove remaining references to 'idv/doc_auth' in specs and a comment * Remove ref to user_session['idv'] 1) it's not a hash, it's an Idv::Session; and 2) we use user_session[:idv] everywhere
mitchellhenke
approved these changes
Oct 3, 2023
mdiarra3
approved these changes
Oct 3, 2023
soniaconnolly
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features